Fix QIT errors reported by PHPStan #8845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
timur27
force-pushed
the
fix/phpstan-errors
branch
from
3f9324b
to
e7aaf6c
Compare
timur27
force-pushed
the
fix/phpstan-errors
branch
from
4986fb9
to
53a8480
Compare
…into fix/phpstan-errors
timur27
force-pushed
the
fix/phpstan-errors
branch
from
d89a7cc
to
e0f96bf
Compare
ricardo
reviewed
May 24, 2024
| @@ -55,6 +55,7 @@ public function get_args() { | |||
| * @psalm-suppress UndefinedMethod | |||
| */ | |||
| public function get_cart_token() { | |||
| // @phpstan-ignore-next-line. | |||
| return parent::get_cart_token(); | |||
mdmoore
approved these changes
May 30, 2024
jessepearson
reviewed
Jun 3, 2024
| @@ -63,7 +63,7 @@ public function add_initial_currency( $cart_item, $product_id, $variation_id ) { | |||
|
|
|||
| $nyp_id = $variation_id ? $variation_id : $product_id; | |||
|
|
|||
| if ( \WC_Name_Your_Price_Helpers::is_nyp( $nyp_id ) && isset( $cart_item['nyp'] ) ) { | |||
| if ( class_exists( '\WC_Name_Your_Price_Helpers' ) && \WC_Name_Your_Price_Helpers::is_nyp( $nyp_id ) && isset( $cart_item['nyp'] ) ) { | |||
There was a problem hiding this comment.
This check makes sense since we were assuming the Name Your Price plugin would always have the helper class when it may not.
jessepearson
reviewed
Jun 3, 2024
| @@ -125,8 +125,10 @@ public function get_item_data( $addon_data, $addon, $cart_item ): array { | |||
| // Quantity/multiplier add on needs to be split, calculated, then multiplied by input value. | |||
| $price = $this->multi_currency->get_price( $addon['price'] / $addon['value'], 'product' ) * $addon['value']; | |||
| } | |||
| $price = \WC_Product_Addons_Helper::get_product_addon_price_for_display( $price, $cart_item['data'] ); | |||
| $name .= ' (' . wc_price( $price ) . ')'; | |||
| if ( class_exists( '\WC_Product_Addons_Helper' ) ) { | |||
There was a problem hiding this comment.
This check makes sense since we were assuming the Product Addons plugin would always have the helper class when it may not.
…into fix/phpstan-errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8817
Changes proposed in this Pull Request
This PR fixes the PHPStan errors reported by QIT tests.
Testing instructions
npm run test:qit-phpstan-localon thedevelopbranch reveals 27 errors.npm run test:qit-phpstan-localon this branch results in a successful test outcome.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge